That's because catching shinies is incredibly difficult. I can't remember if it was HG/SS or B/W, but one of them had an improved chance of catching shinies.
http://www.serebii.net/games/shiny.shtml I believe that page should educate you further on them. Generally, you have a 1 in 8,000 chance of catching a shiny. You've only seen them in those two occasions because;
1) You got it through trade - Someone else either made that Pokemon through Action Replay, or found it themselves through pure luck. You're working off of either their cheating nature or luck.
2) The red Gyarados is a given - I think it's really the only shiny Pokemon you'll be given through a small adventure in these games. Aside from that Pokemon, the game is stingy when it comes to shinies.
If you want to CATCH a shiny of your own, you're going to have to run around in the grass patches for a few hours/days/months/etc. It all depends on how unlucky you are.
NOTE: I'm an idiot when it comes to Pokemon. There's a good chance that everything I said was a complete load of BS.
Also, I hate that you got banned, but we can't allow any active users on our site that are under the age of 13. I'm sure since you came to us for help, you'll read the thread, though.