There's too many films for me to say what my favourite one ever is so I've split them up into sections but even then it's still difficult.
Horror: The Exorcist
Sci-Fi: Star Wars (IV - 1977)
Western: The Outlaw Josey Wales
War: The Great Escape
Comedy: Lock Stock and Two Smoking Barrels
Thriller: Silence of the Lambs